feat: Added support for Java 17 #207
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
reviewed
Jan 10, 2024
android/build.gradle
Outdated
| @@ -68,13 +68,16 @@ afterEvaluate { | |||
| android { | |||
| compileSdkVersion safeExtGet("compileSdkVersion", 31) | |||
There was a problem hiding this comment.
With the bump to 17 for the java version we can probably bump the compile version to the latest as well.
Suggested change
| compileSdkVersion safeExtGet("compileSdkVersion", 31) | |
| compileSdkVersion safeExtGet("compileSdkVersion", 34) |
alexrisch
force-pushed
the
ar/java-17-support
branch
2 times, most recently
from
8c21e8e to
7ab49f2
Compare
nplasterer
approved these changes
Jan 11, 2024
alexrisch
force-pushed
the
ar/java-17-support
branch
from
7ab49f2 to
98d57a9
Compare
Fix issue: > 'compileDebugJavaWithJavac' task (current target is 17) and 'compileDebugKotlin' task (current target is 11) jvm target compatibility should be set to the same Java version. Seen when working with React Native 0.73 project Bumped compile sdk to 34
alexrisch
force-pushed
the
ar/java-17-support
branch
from
98d57a9 to
9c65831
Compare
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue:
Seen when working with React Native 0.73 project